-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swift package manager #242
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick review of the changes.
nit: I have tested both CocoaPods and SPM within the example (turning on and off SPM) but it might be a good idea to automate this check in CI, We often don't need this since this one package and it would complicate the process. |
This doesn't apply to Swift code (false positive). |
Thank you for your contribution @EchoEllet !
Can you follow the rules? |
Single quotes ( // This won't compile
.process('PrivacyInfo.xcprivacy'), This warning is in the file |
I think the warning is for trailing comma @EchoEllet |
I have added a single trailing newline to the file |
] | ||
) | ||
] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running wc -l darwin/gal/Package.swift
outputs 25
when it's 26
lines in the code editor and actual file, it's likely a configuration issue in Git (related to line-endings) or the editor in my local machine. I added another line from my end so it appears only one empty line at the end from remote.
@EchoEllet Oh no. Please do not stop adding Privacy Manifest. It is fine without it, but adding an empty Privacy Manifest is a better choice. Can you revert 83f710d? |
This reverts commit 83f710d.
By empty, I think they meant empty values, they said |
Overview
Adds support for SPM following the Flutter instructions.
Related Issues